Add .editorconfig and reformat code #32
Conversation
build.gradle.kts
Outdated
| spotless { | ||
| kotlin { | ||
| ktlint(libs.ktlint.get().version) | ||
| } | ||
| kotlinGradle { | ||
| ktlint(libs.ktlint.get().version) | ||
| } | ||
| } |
There was a problem hiding this comment.
Is that going to fail the build everytime there is a code style violation?
As much as I welcome .editorconfig (and even better, .idea/codeStyle), I have very mixed feelings about adding more friction to development. This blog post explains why
There was a problem hiding this comment.
Yeah, check depends on spotlessCheck.
.editorconfig would be enough, it's honored by IDEA, VSC, and others.
There was a problem hiding this comment.
LGTM 👍 Can you keep .editorconfig but remove spotless?
There was a problem hiding this comment.
I can. But some rules break the rules, e.g.
Line 11 in 350f1f3
There was a problem hiding this comment.
Not sure I'm following. Do you mean that some of the existing code breaks the rule? This is fine, we can reformat as we go. Or just commit the reformat alongside .editorconfig
Goooler
force-pushed
the
g/20250422/editorconfig
branch
from
92726e4 to
5dfacb3
Compare
Mostly copy-pasted from https://github.com/GradleUp/shadow/blob/main/.editorconfig
Closes #31.