Split the plugin in 2 parts: regular and aggregation #29

martinbonnin · 2025-04-21T15:43:17Z

See #23

vlsi

There are quite a few changes going on here

CHANGELOG.md

build.gradle.kts

src/main/kotlin/nmcp/NmcpAggregationExtension.kt

src/main/kotlin/nmcp/internal/plugins.kt

src/main/kotlin/nmcp/internal/task/publish.kt

src/main/kotlin/nmcp/NmcpExtension.kt

tests/jvm/build.gradle.kts

tests/kmp/build.gradle.kts

build.gradle.kts

src/main/kotlin/nmcp/NmcpAggregationExtension.kt

src/main/kotlin/nmcp/internal/task/NmcpZip.kt

src/main/kotlin/nmcp/internal/task/publish.kt

Co-authored-by: Vladimir Sitnikov <[email protected]>

src/main/kotlin/nmcp/NmcpAggregationExtension.kt

src/main/kotlin/nmcp/NmcpExtension.kt

Co-authored-by: Vladimir Sitnikov <[email protected]>

vlsi · 2025-04-24T05:47:28Z

src/main/kotlin/nmcp/NmcpAggregationExtension.kt

+    init {
+        val operations = archiveOperations
+        val layout = project.layout
+        val files= project.files(consumerConfiguration)


project.files(consumerConfiguration) seems redundand as consumerConfiguration.elements is just fine below, isn't it?

It uses files.elements (on line 35). CC doesn't like to serialize configurations. My understanding is that it needs to go through files.

martinbonnin · 2025-04-24T13:39:17Z

I'm merging this one, there's been a lot of good discussions, thanks a lot @vlsi!

Will follow up about #21, #33 and #34 in separate PRs. Hopefully targetting a release over the week end or so 🤞

martinbonnin · 2025-04-24T20:41:13Z

I ended up doing a 0.1.0 release today because the README was becoming out of sync and I'd rather have people use the new way moving forward. Will look into #21 and #33 for 0.1.1.

martinbonnin added 2 commits April 21, 2025 11:59

wip

1fa7ecd

Split the plugin in 2

281fa66

martinbonnin mentioned this pull request Apr 21, 2025

Consider splitting the plugin in two: base and aggregate #23

Closed

update CHANGELOG

87d59e6

vlsi reviewed Apr 21, 2025

View reviewed changes

martinbonnin added 6 commits April 21, 2025 23:30

remove leftovers

7ac3e89

Remove the plugin boilerplate

ac9d7db

tweak error message, thanks @vlsi!

05d0ea0

put smaller code first

7c30fe3

tweak message

79fe2c9

fix wording

1d43f45

vlsi reviewed Apr 22, 2025

View reviewed changes

build.gradle.kts Outdated Show resolved Hide resolved

vlsi reviewed Apr 22, 2025

View reviewed changes

src/main/kotlin/nmcp/NmcpAggregationExtension.kt Outdated Show resolved Hide resolved

vlsi reviewed Apr 22, 2025

View reviewed changes

src/main/kotlin/nmcp/internal/task/NmcpZip.kt Outdated Show resolved Hide resolved

vlsi reviewed Apr 22, 2025

View reviewed changes

src/main/kotlin/nmcp/internal/task/publish.kt Outdated Show resolved Hide resolved

vlsi reviewed Apr 22, 2025

View reviewed changes

src/main/kotlin/nmcp/internal/task/publish.kt Show resolved Hide resolved

vlsi reviewed Apr 22, 2025

View reviewed changes

src/main/kotlin/nmcp/internal/task/publish.kt Outdated Show resolved Hide resolved

vlsi reviewed Apr 22, 2025

View reviewed changes

src/main/kotlin/nmcp/internal/task/publish.kt Outdated Show resolved Hide resolved

martinbonnin and others added 7 commits April 22, 2025 14:10

Remove verifyStatus

6f0706b

remove useless code

4e7a93d

Use aggregation consistently

3b41d9e

remove unused class

8234974

Update src/main/kotlin/nmcp/internal/task/publish.kt

f063a3f

Co-authored-by: Vladimir Sitnikov <[email protected]>

Update src/main/kotlin/nmcp/internal/task/publish.kt

baf5bb2

Co-authored-by: Vladimir Sitnikov <[email protected]>

Update src/main/kotlin/nmcp/internal/task/publish.kt

adb9d56

Co-authored-by: Vladimir Sitnikov <[email protected]>

vlsi reviewed Apr 22, 2025

View reviewed changes

src/main/kotlin/nmcp/NmcpAggregationExtension.kt Show resolved Hide resolved

vlsi reviewed Apr 22, 2025

View reviewed changes

src/main/kotlin/nmcp/NmcpAggregationExtension.kt Outdated Show resolved Hide resolved

vlsi reviewed Apr 22, 2025

View reviewed changes

src/main/kotlin/nmcp/NmcpAggregationExtension.kt Outdated Show resolved Hide resolved

martinbonnin added 2 commits April 22, 2025 14:35

Merge branch 'main' into rearchitecture

9a15ce7

unbreak tests

6dde059

NmcpSpec -> CentralPortalOptions

95fe190

vlsi reviewed Apr 22, 2025

View reviewed changes

src/main/kotlin/nmcp/NmcpExtension.kt Outdated Show resolved Hide resolved

martinbonnin and others added 2 commits April 22, 2025 15:24

Update src/main/kotlin/nmcp/NmcpExtension.kt

424ef0b

Co-authored-by: Vladimir Sitnikov <[email protected]>

configuration cache

de6e2e5

martinbonnin mentioned this pull request Apr 22, 2025

Avoid zipping/unzipping the outgoing variants #33

Closed

martinbonnin added 2 commits April 22, 2025 15:44

missing parenthesis

7f3279b

unbreak tests

2504216

vlsi reviewed Apr 24, 2025

View reviewed changes

martinbonnin added 2 commits April 24, 2025 15:34

format

7cdaf30

Merge branch 'main' into rearchitecture

066ead4

martinbonnin merged commit dd498ba into main Apr 24, 2025
1 check passed

martinbonnin deleted the rearchitecture branch April 24, 2025 13:39

martinbonnin changed the title ~~Split the plugin in 2~~ Split the plugin in 2 parts: regular and aggregation May 26, 2025

martinbonnin mentioned this pull request Jun 16, 2025

Ability to specify Maven publication #84

Closed

Split the plugin in 2 parts: regular and aggregation #29

Split the plugin in 2 parts: regular and aggregation #29

Uh oh!

Conversation

martinbonnin commented Apr 21, 2025

Uh oh!

vlsi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vlsi Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

martinbonnin Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

martinbonnin commented Apr 24, 2025

Uh oh!

Uh oh!

martinbonnin commented Apr 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants