Skip to content

fix(#3072): angular reset and value binding issue #3107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from
Open

fix(#3072): angular reset and value binding issue #3107

wants to merge 1 commit into from

Conversation

@syedszeeshan
Copy link
Collaborator

@syedszeeshan syedszeeshan commented Oct 15, 2025 •
edited
Loading

Before (the change)

After (the change)

Make sure that you've checked the boxes below before you submit the PR

  • I have read and followed the setup steps
  • I have created necessary unit tests
  • I have tested the functionality in both React and Angular.

Steps needed to test

@syedszeeshan syedszeeshan linked an issue Oct 16, 2025 that may be closed by this pull request
Value binding required for Reactive Forms #3072
Open
@syedszeeshan syedszeeshan marked this pull request as ready for review October 16, 2025 20:20
vanessatran-ddi
vanessatran-ddi reviewed Oct 20, 2025
View reviewed changes
libs/angular-components/src/lib/components/input/input.ts Outdated
}
}

override writeValue(value: unknown): void {
Copy link
Collaborator

@vanessatran-ddi vanessatran-ddi Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Input/Textarea/RadioGroup writeValue are quite identical, the Dropdown has the function slightly different: check !value , and Checkbox is a unique case, I am thinking if we have a way to elimiate the duplication?

@syedszeeshan syedszeeshan marked this pull request as draft October 22, 2025 20:53
@syedszeeshan syedszeeshan force-pushed the Syed/3072-UI branch 3 times, most recently from 122b961 to 1fa52d8 Compare October 23, 2025 17:30
@syedszeeshan syedszeeshan marked this pull request as ready for review October 23, 2025 18:32
vanessatran-ddi
vanessatran-ddi reviewed Oct 28, 2025
View reviewed changes
Copy link
Collaborator

@vanessatran-ddi vanessatran-ddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only 1 comment left for the date-picker.ts, the rest looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vanessatran-ddi vanessatran-ddi vanessatran-ddi approved these changes

@ArakTaiRoth ArakTaiRoth Awaiting requested review from ArakTaiRoth

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Value binding required for Reactive Forms

3 participants

@syedszeeshan @vanessatran-ddi