-
Notifications
You must be signed in to change notification settings - Fork 34
feat(#3096): update Temporary Notification component for V2 #3106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2-2998-coded-component-updates
Are you sure you want to change the base?
feat(#3096): update Temporary Notification component for V2 #3106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! There are a couple spots where we can keep those tokens.
libs/web-components/src/components/temporary-notification/TemporaryNotification.svelte
Outdated
Show resolved
Hide resolved
libs/web-components/src/components/temporary-notification/TemporaryNotification.svelte
Outdated
Show resolved
Hide resolved
c445b0a to
9b67464
Compare
|
@bdfranck I committed your suggested changes and squashed it back into one commit for us to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just have two more questions about the margins around the icon.
libs/web-components/src/components/temporary-notification/TemporaryNotification.svelte
Outdated
Show resolved
Hide resolved
libs/web-components/src/components/temporary-notification/TemporaryNotification.svelte
Outdated
Show resolved
Hide resolved
9b67464 to
1a665b5
Compare
@bdfranck I appreciate the review, it should be fixed now, I've pushed updates to both this PR and the related design tokens PR GovAlta/design-tokens#98. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Summary
Updates the Temporary Notification (Snackbar) component to use a
comprehensive token-driven architecture. This component previously had all
styling hardcoded - this PR converts all CSS properties to use design
tokens with proper fallback values for V1 compatibility.
Classification: Token-Only (no version prop needed)
Changes
Token Integration
Converted all hardcoded CSS values to use design tokens with fallback
pattern:
Example conversions:
var(--goa-temporary-notification-borderRadius, var(--goa-border-radius-m))
var(--goa-temporary-notification-padding, var(--goa-space-m)
var(--goa-space-l))
Spacing Improvements
Flexbox Gap Structure:
Icon Spacing:
No Version Prop Required
This component is Token-Only - no structural or behavioral changes between V1 and V2:
progress)
Technical Implementation
All 22 tokens created with fallback pattern ensures:
Related