feat(#2915): callout v2 layout and emphasis levels #3100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdfranck
force-pushed
the
benjifranck/v2-callout-update
branch
from
9c3ec2c to
caf6669
Compare
twjeffery
requested changes
Oct 27, 2025
There was a problem hiding this comment.
Looks great @bdfranck , just a couple adjustments suggested below.
Also, it looks like the heading font-weight is showing up as bold, not semi-bold. Now that I look at it, I think it's the same for the Modal heading where it uses semi-bold. It is showing font-weight 600, but visually looks off. Maybe we can connect to figure this one out.
Coded component (left), Figma component (right):
| .v2.notification .heading { | ||
| display: flex; | ||
| flex-direction: row; | ||
| align-items: center; |
There was a problem hiding this comment.
This should be flex-start so that the icon lines up with the first line when the heading wraps to more than one line.
Suggested change
| align-items: center; | |
| align-items: flex-start; |
| } | ||
| .v2.notification .heading-label { | ||
| margin-bottom: 0; |
There was a problem hiding this comment.
I think this should be:
- margin-top: space-3xs
- to better vertically align the heading text with the icon
- margin-bottom: space-3xs
- to better vertically center the heading content within the heading container
Margin-top/bottom: 2xs
Margin: 0
Suggested change
| margin-bottom: 0; | |
| margin-top: var(--goa-space-3xs); | |
| margin-bottom: var(--goa-space-3xs); |
| .v2.emphasis-low .heading-label:empty { | ||
| display: none; | ||
| } | ||
There was a problem hiding this comment.
This adjusts the "gap" between the icon and the content (when no header) to 8px instead of 12px
Suggested change
| .v2.emphasis-low:has(.heading-label:empty) .heading { | |
| padding-right: var(--goa-space-xs); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the callout to matches the new v2 Callout component. It makes the following changes: