Skip to content

Conversation

@chrisolsen
Copy link
Collaborator

@chrisolsen chrisolsen commented Oct 8, 2025

Before (the change)

The ui-components-common libs was published to npm and teams were required to manually add that lib to the package file.

After (the change)

Teams will no longer need to install the ui-components-common lib, but rather the common files will be bundled up in both the Angular and React library.

Steps needed to test

  • Test to ensure that the existing playground works for both React and Angular
  • Test to ensure that an existing non-Nx app works with the new bunlded up libs AND when the existing ui-components-common npm lib has been manually installed (to ensure existing apps won't break)
  • Test that a new (non-Nx) project works with just the React or Angular lib that has the common lib bundled up.

@chrisolsen chrisolsen marked this pull request as ready for review October 9, 2025 15:44
@chrisolsen chrisolsen marked this pull request as draft October 9, 2025 15:50
@chrisolsen chrisolsen force-pushed the chris/2674-common-lib-fix branch from e137f54 to 465d12c Compare October 10, 2025 20:44
@chrisolsen chrisolsen marked this pull request as ready for review October 10, 2025 20:44
@chrisolsen chrisolsen marked this pull request as draft October 10, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants