feat(#3070): v2 badge with emphasis and size #3097
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdfranck
force-pushed
the
benjifranck/3070-v2-badge-update
branch
from
633ba13 to
a2f80e9
Compare
bdfranck
changed the title
bdfranck
force-pushed
the
benjifranck/3070-v2-badge-update
branch
2 times, most recently
from
39716fb to
964e764
Compare
bdfranck
commented
Oct 7, 2025
| setTimeout(() => validateType(type), 1); | ||
| setTimeout(() => { | ||
| if (version === "2" && !type) { | ||
| type = "default"; |
There was a problem hiding this comment.
Type is required in v1 but optional in v2. I'm not sure if this is the best approach. Maybe we could handle it in the wrappers or rethink how to have a default option.
There was a problem hiding this comment.
should we keep it required in both? I know we have a default badge type, but I don't know if that's expected.
twjeffery
requested changes
Oct 27, 2025
| setTimeout(() => validateType(type), 1); | ||
| setTimeout(() => { | ||
| if (version === "2" && !type) { | ||
| type = "default"; |
There was a problem hiding this comment.
should we keep it required in both? I know we have a default badge type, but I don't know if that's expected.
|
@twjeffery I've amended my commit with the following changes:
|
bdfranck
force-pushed
the
benjifranck/3070-v2-badge-update
branch
from
964e764 to
b71f24f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the badge component to match the v2 styles and adds two new properties: size and emphasis.