Add support for s3-compatible storage #3924
Conversation
| } | ||
| std::string aws_endpoint_url = Context::getContext().config.get("sync.aws.endpoint_url"); | ||
| bool aws_force_path_style = | ||
| Context::getContext().config.getBoolean("sync.aws.force_path_style"); |
There was a problem hiding this comment.
What value does this need to take when it and aws_endpoint_url are omitted? I assume this call will default to false when the config is not provided.
There was a problem hiding this comment.
We'll also need to update the docs as to when region is required, and allow it to be empty in other cases.
There was a problem hiding this comment.
Indeed, this defaults to false.
I believe AWS will actually work with both aws_force_path_style = false and aws_force_path = true!
:ack: on the docs here, I need to start editing ./doc/man/task-sync.5
Yeah! I had a successful sync to a rook-ceph object store by using the instructions in: https://github.com/GothenburgBitFactory/taskwarrior/blob/bba38b00f8d4735dc260deea3c05a302fb878474/doc/devel/contrib/development.md#using-a-custom-version-of-taskchampion I should be able to get to the feedback today or tomorrow! |
|
I'm really busy too, so take your time but please let me know if you feel like "tomorrow" slips into "never" :) |
2 participants
Utilizes GothenburgBitFactory/taskchampion#601
Will rewrite PR description and move out of draft