Skip to content

Conversation

xeruf
Copy link
Contributor

@xeruf xeruf commented May 28, 2020

Fixes #77

Copy link
Collaborator

@robgolding robgolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xerus2000! I'd love to get this merged, though it really needs some tests before we can do so. Could you also check out my comment below?

Thanks so much!


def serialize_tags(self, tags):
return ','.join(tags) if tags else ''
return list(tags)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of the serialization is to turn the object into a string representation, so this should be cast as a string.

That said, I am not yet entirely convinced this would work (i.e. with older versions of the TW). Maybe we can revive travis @robgolding ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been using this branch for weeks with the latest taskwarrior version. The only issue that arose (#83) was due to me not knowing python well and is now fixed.
Why would we need to support old taskwarrior versions with new releases?

Reviving travis sounds good anyways though.

@dkasak
Copy link

dkasak commented May 26, 2023

As detailed in tbabej/taskpirate#19 and #77 the bug this PR is fixing is biting people by silently corrupting data. What can we do to help land this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tags should be export as list

4 participants