Fix rustdoc not-a-link #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmitche
approved these changes
Aug 10, 2025
Collaborator
djmitche
left a comment
djmitche
left a comment
There was a problem hiding this comment.
I don't totally understand either, but if the robots are OK with it then I am too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #601 we noticed a new failure on rustdoc.
It wasn't happening locally for me, so I went and checked with nightly (it looks like our
rustdocaction uses nightly) + the recent changelog for rust. This landed just a few days ago: rust-lang/rust/pull/132748 and seems very suspiciously the culprit.I don't fully understand what our intention was here, but I swapped to no backticks based on this comment:
// If there's no backticks, be lenient and revert to the old behavior.I have no idea if this was the right solution, besides the fact CI passes 🤣 .