Abrar/feature/performance score frontend#389
Open
abrar-deakin wants to merge 9 commits into
Open
Conversation
Collaborator
|
Code Review Summary In your previous submission, you have the wrong type of API response. Without proper decomposition or data massaging, this is what you have done 
Actual shape of "data" from the API response Because of this, the score of a guard will forever be '0.0' |
Collaborator
Author
|
I have addressed the review comments and fixed the API response handling issue. The performance score is now displaying correctly on both the Home and Profile screens. Please see the updated screenshots attached. Thank you! 
|
Collaborator
|
Request changes. The core feature works, but the duplicate API call in HomeScreen, copy-pasted logic across screens, and leftover console.log statements should be addressed before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented performance scoring endpoint integration into frontend.
Changes: