Skip to content

Added improvements#395

Open
akashgajjala01 wants to merge 1 commit into
masterfrom
Akash/Doctor-dashboard
Open

Added improvements#395
akashgajjala01 wants to merge 1 commit into
masterfrom
Akash/Doctor-dashboard

Conversation

@akashgajjala01
Copy link
Copy Markdown
Collaborator

Description

[Describe the change that was made in this PR]

Todos

  • Tested and working locally
  • Code follows the style guidelines of this project
  • I have performed a self-review of my code
  • Code changes documented
  • Requested review from >= 2 devs on the team (one frontend and one backend recommended)

How to test

[Add detailed steps to test the changes that have been made]

Screenshots and/or Gifs

[Insert screenshots and/or gifs showing the graphic representation of the change]

Associated MS Planner Tasks

Known Issues

[Describe any known issue with this change]

Copy link
Copy Markdown
Collaborator

@SHUBHAM-2305 SHUBHAM-2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks like a helpful UI improvement. I tested the doctor dashboard page locally, and the page loads properly, I reviewed it mainly from a UI and layout perspective. One thing worth considering before approval is that the doctor homepage currently uses quite fixed spacing and positioning for the buttons and sections. While it looks fine on the device I tested, making the styling a bit more responsive would help the page scale better across different screen sizes. It would also be better to move the newly added user-facing strings into strings.xml instead of hardcoding them in XML, as that would improve consistency and maintainability.

Overall, this is a good first step for building the doctor dashboard UI, and the page looks good visually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants