-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: 3.5.0 post release updates #4460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @diegomarquezp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs routine post-release updates, ensuring that all Jib examples and documentation reflect the newly released version 3.5.1. It incorporates the latest features, such as Java 25 main method support, and critical dependency updates to keep the project current and compatible. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Jib plugin and core library versions across the example projects and documentation to 3.5.1 and 0.28.1 respectively. The changelogs have also been updated to reflect the new features and dependency updates for this release.
The changes are mostly correct and consistent. I've found one minor issue in the documentation that could be improved.
Also, the pull request title "chore: 3.5.0 post release updates" seems a bit misleading, as the changes are for the 3.5.1 release. You might want to consider updating it to something like "chore: Prepare for 3.5.1 release" for clarity.
| ```groovy | ||
| dependencies { | ||
| compile 'com.google.cloud.tools:jib-core:0.28.0' | ||
| compile 'com.google.cloud.tools:jib-core:0.28.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.