-
Notifications
You must be signed in to change notification settings - Fork 1.5k
core release v0.28.1 #4456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core release v0.28.1 #4456
Conversation
Summary of ChangesHello @cloud-java-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the development version of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request performs a post-release version bump for the jib-core module from 0.28.1-SNAPSHOT to 0.28.2-SNAPSHOT, following the v0.28.1 release. While the version change is appropriate for the next development cycle, the manual process could be improved. I have provided a suggestion to automate this step using the existing Gradle release plugin, which would enhance the robustness and consistency of the release workflow.
| @@ -1 +1 @@ | |||
| version = 0.28.1-SNAPSHOT | |||
| version = 0.28.2-SNAPSHOT | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This manual version bump appears to be a post-release task. The net.researchgate.release plugin, which is already configured in jib-core/build.gradle, can automate this process. Relying on manual version updates is error-prone. I recommend leveraging the release plugin to handle versioning automatically. This would typically involve a command like gradle release which would create a release commit/tag and a subsequent commit for the next development version, leading to a more robust and consistent release process.
To be merged after the release is complete.