Refactor oracle.go to improve code readability and testability. #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_856418402
branch
13 times, most recently
from
9c1ee58 to
c9203c2
Compare
key changes: 1. Introduced DiscoveryClient and MetricsCollector interfaces. The Service struct now holds these dependencies. This allows mocking implementations to be injected during tests. discoveryClient is held as an instance (since it's stateless), and MetricsCollector is created via a factory function (newMetricsCollector) because it is stateful (holds DB connections) and runs inside a recoverable routine that may need to recreate it upon restart. 2. Extracted logic from the Start method into smaller helper methods: waitForWorkload, startDiscoveryRoutine, startMetricCollectionRoutine, and startGuestActionsRoutine. This separates concerns and makes the code easier to follow and allows testing of individual components. 3. Replaced blocking time.Sleep call with a select statement listening to ctx.Done(). This makes sure the service responds immediately to cancellation requests instead of waiting for the sleep interval to complete. PiperOrigin-RevId: 856817758
copybara-service
bot
force-pushed
the
test_856418402
branch
from
c9203c2 to
8a7dad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor oracle.go to improve code readability and testability.
key changes:
Introduced DiscoveryClient and MetricsCollector interfaces.
The Service struct now holds these dependencies. This allows mocking implementations to be injected during tests.
discoveryClient is held as an instance (since it's stateless), and MetricsCollector is created via a factory function (newMetricsCollector) because it is stateful (holds DB connections) and runs inside a recoverable routine that may need to recreate it upon restart.
Extracted logic from the Start method into smaller helper methods: waitForWorkload, startDiscoveryRoutine, startMetricCollectionRoutine, and startGuestActionsRoutine.
This separates concerns and makes the code easier to follow and allows testing of individual components.
Replaced blocking time.Sleep call with a select statement listening to ctx.Done(). This makes sure the service responds immediately to cancellation requests instead of waiting for the sleep interval to complete.