-
Notifications
You must be signed in to change notification settings - Fork 13
Enable DaemonSet configuration #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brunohoff
wants to merge
4
commits into
GoogleCloudPlatform:main
Choose a base branch
from
brunohoff:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8582e08
Added support to DaemonSet
brunohoffmeister 06b006e
Duplicace base code to daemonset
brunohoffmeister 3323c7a
Adjust daemonset to prefer closer traffic and deployment to have a zo…
brunohoff 932e123
Optimize DaemonSet and Deployment. Created overlay for high availability
brunohoffmeister File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Copyright 2024 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| apiVersion: v1 | ||
| kind: Namespace | ||
| metadata: | ||
| name: opentelemetry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,234 @@ | ||
| apiVersion: v1 | ||
| data: | ||
| collector.yaml: | | ||
| # Copyright 2024 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| exporters: | ||
| googlecloud: | ||
| log: | ||
| default_log_name: opentelemetry-collector | ||
| user_agent: Google-Cloud-OTLP manifests:0.5.0 OpenTelemetry Collector Built By Google/0.131.0 (linux/amd64) | ||
| googlemanagedprometheus: | ||
| user_agent: Google-Cloud-OTLP manifests:0.5.0 OpenTelemetry Collector Built By Google/0.131.0 (linux/amd64) | ||
| # The otlphttp exporter is used to send traces to Google Cloud Trace using OTLP http/proto | ||
| # The otlp exporter could also be used to send them using OTLP grpc | ||
| otlphttp: | ||
| encoding: proto | ||
| endpoint: https://telemetry.googleapis.com | ||
| # Use the googleclientauth extension to authenticate with Google credentials | ||
| auth: | ||
| authenticator: googleclientauth | ||
|
|
||
|
|
||
| extensions: | ||
| health_check: | ||
| endpoint: ${env:MY_POD_IP}:13133 | ||
| googleclientauth: | ||
|
|
||
|
|
||
| processors: | ||
| filter/self-metrics: | ||
| metrics: | ||
| include: | ||
| match_type: strict | ||
| metric_names: | ||
| - otelcol_process_uptime | ||
| - otelcol_process_memory_rss | ||
| - otelcol_grpc_io_client_completed_rpcs | ||
| - otelcol_googlecloudmonitoring_point_count | ||
| batch: | ||
| send_batch_max_size: 200 | ||
| send_batch_size: 200 | ||
| timeout: 5s | ||
|
|
||
| k8sattributes: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please follow https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/k8sattributesprocessor#deployment-scenarios to set the in DS mode so the collector won't buffer all pods in the cluster. |
||
| filter: | ||
| node_from_env_var: KUBE_NODE_NAME | ||
| extract: | ||
| metadata: | ||
| - k8s.namespace.name | ||
| - k8s.deployment.name | ||
| - k8s.statefulset.name | ||
| - k8s.daemonset.name | ||
| - k8s.cronjob.name | ||
| - k8s.job.name | ||
| - k8s.replicaset.name | ||
| - k8s.node.name | ||
| - k8s.pod.name | ||
| - k8s.pod.uid | ||
| - k8s.pod.start_time | ||
| passthrough: false | ||
| pod_association: | ||
| - sources: | ||
| - from: resource_attribute | ||
| name: k8s.pod.ip | ||
| - sources: | ||
| - from: resource_attribute | ||
| name: k8s.pod.uid | ||
| - sources: | ||
| - from: connection | ||
|
|
||
| memory_limiter: | ||
| check_interval: 1s | ||
| limit_percentage: 65 | ||
| spike_limit_percentage: 20 | ||
|
|
||
| metricstransform/self-metrics: | ||
| transforms: | ||
| - action: update | ||
| include: otelcol_process_uptime | ||
| operations: | ||
| - action: add_label | ||
| new_label: version | ||
| new_value: Google-Cloud-OTLP manifests:0.5.0 OpenTelemetry Collector Built By Google/0.131.0 (linux/amd64) | ||
|
|
||
| resourcedetection: | ||
| detectors: [gcp] | ||
| timeout: 10s | ||
|
|
||
| transform/collision: | ||
| metric_statements: | ||
| - context: datapoint | ||
| statements: | ||
| - set(attributes["exported_location"], attributes["location"]) | ||
| - delete_key(attributes, "location") | ||
| - set(attributes["exported_cluster"], attributes["cluster"]) | ||
| - delete_key(attributes, "cluster") | ||
| - set(attributes["exported_namespace"], attributes["namespace"]) | ||
| - delete_key(attributes, "namespace") | ||
| - set(attributes["exported_job"], attributes["job"]) | ||
| - delete_key(attributes, "job") | ||
| - set(attributes["exported_instance"], attributes["instance"]) | ||
| - delete_key(attributes, "instance") | ||
| - set(attributes["exported_project_id"], attributes["project_id"]) | ||
| - delete_key(attributes, "project_id") | ||
|
|
||
| # The relative ordering of statements between ReplicaSet & Deployment and Job & CronJob are important. | ||
| # The ordering of these controllers is decided based on the k8s controller documentation available at | ||
| # https://kubernetes.io/docs/concepts/workloads/controllers. | ||
| # The relative ordering of the other controllers in this list is inconsequential since they directly | ||
| # create pods. | ||
| transform/aco-gke: | ||
| metric_statements: | ||
| - context: datapoint | ||
| statements: | ||
| - set(attributes["top_level_controller_type"], "ReplicaSet") where resource.attributes["k8s.replicaset.name"] != nil | ||
| - set(attributes["top_level_controller_name"], resource.attributes["k8s.replicaset.name"]) where resource.attributes["k8s.replicaset.name"] != nil | ||
| - set(attributes["top_level_controller_type"], "Deployment") where resource.attributes["k8s.deployment.name"] != nil | ||
| - set(attributes["top_level_controller_name"], resource.attributes["k8s.deployment.name"]) where resource.attributes["k8s.deployment.name"] != nil | ||
| - set(attributes["top_level_controller_type"], "DaemonSet") where resource.attributes["k8s.daemonset.name"] != nil | ||
| - set(attributes["top_level_controller_name"], resource.attributes["k8s.daemonset.name"]) where resource.attributes["k8s.daemonset.name"] != nil | ||
| - set(attributes["top_level_controller_type"], "StatefulSet") where resource.attributes["k8s.statefulset.name"] != nil | ||
| - set(attributes["top_level_controller_name"], resource.attributes["k8s.statefulset.name"]) where resource.attributes["k8s.statefulset.name"] != nil | ||
| - set(attributes["top_level_controller_type"], "Job") where resource.attributes["k8s.job.name"] != nil | ||
| - set(attributes["top_level_controller_name"], resource.attributes["k8s.job.name"]) where resource.attributes["k8s.job.name"] != nil | ||
| - set(attributes["top_level_controller_type"], "CronJob") where resource.attributes["k8s.cronjob.name"] != nil | ||
| - set(attributes["top_level_controller_name"], resource.attributes["k8s.cronjob.name"]) where resource.attributes["k8s.cronjob.name"] != nil | ||
|
|
||
| # When sending telemetry to the GCP OTLP endpoint, the gcp.project_id resource attribute is required to be set to your project ID. | ||
| resource/gcp_project_id: | ||
| attributes: | ||
| - key: gcp.project_id | ||
| # MAKE SURE YOU REPLACE THIS WITH YOUR PROJECT ID | ||
| value: ${GOOGLE_CLOUD_PROJECT} | ||
| action: insert | ||
| # The metricstarttime processor is important to include if you are using the prometheus receiver to ensure the start time is set properly. | ||
| # It is a no-op otherwise. | ||
| metricstarttime: | ||
| strategy: subtract_initial_point | ||
|
|
||
| receivers: | ||
| # This collector is configured to accept OTLP metrics, logs, and traces, and is designed to receive OTLP from workloads running in the cluster. | ||
| otlp: | ||
| protocols: | ||
| grpc: | ||
| endpoint: ${env:MY_POD_IP}:4317 | ||
| http: | ||
| cors: | ||
| allowed_origins: | ||
| - http://* | ||
| - https://* | ||
| endpoint: ${env:MY_POD_IP}:4318 | ||
| otlp/self-metrics: | ||
| protocols: | ||
| grpc: | ||
| endpoint: ${env:MY_POD_IP}:14317 | ||
|
|
||
| service: | ||
| extensions: | ||
| - health_check | ||
| - googleclientauth | ||
| pipelines: | ||
| logs: | ||
| exporters: | ||
| - googlecloud | ||
| processors: | ||
| - k8sattributes | ||
| - resourcedetection | ||
| - memory_limiter | ||
| - batch | ||
| receivers: | ||
| - otlp | ||
| metrics/otlp: | ||
| exporters: | ||
| - googlemanagedprometheus | ||
| processors: | ||
| - k8sattributes | ||
| - memory_limiter | ||
| - metricstarttime | ||
| - resourcedetection | ||
| - transform/collision | ||
| - transform/aco-gke | ||
| - batch | ||
| receivers: | ||
| - otlp | ||
| metrics/self-metrics: | ||
| exporters: | ||
| - googlemanagedprometheus | ||
| processors: | ||
| - filter/self-metrics | ||
| - metricstransform/self-metrics | ||
| - k8sattributes | ||
| - memory_limiter | ||
| - resourcedetection | ||
| - batch | ||
| receivers: | ||
| - otlp/self-metrics | ||
| traces: | ||
| exporters: | ||
| - otlphttp | ||
| processors: | ||
| - k8sattributes | ||
| - memory_limiter | ||
| - resource/gcp_project_id | ||
| - resourcedetection | ||
| - batch | ||
| receivers: | ||
| - otlp | ||
| telemetry: | ||
| logs: | ||
| encoding: json | ||
| metrics: | ||
| readers: | ||
| - periodic: | ||
| exporter: | ||
| otlp: | ||
| protocol: grpc | ||
| endpoint: ${env:MY_POD_IP}:14317 | ||
| kind: ConfigMap | ||
| metadata: | ||
| creationTimestamp: null | ||
| name: collector-config | ||
| namespace: opentelemetry | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| # Copyright 2024 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| apiVersion: v1 | ||
| kind: ServiceAccount | ||
| metadata: | ||
| name: opentelemetry-collector | ||
| namespace: opentelemetry | ||
| labels: | ||
| app.kubernetes.io/name: google-built-opentelemetry-collector | ||
| app.kubernetes.io/version: "0.131.0" | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| name: opentelemetry-collector | ||
| namespace: opentelemetry | ||
| labels: | ||
| app.kubernetes.io/name: google-built-opentelemetry-collector | ||
| app.kubernetes.io/version: "0.131.0" | ||
| rules: | ||
| - apiGroups: [""] | ||
| resources: ["pods", "namespaces", "nodes"] | ||
| verbs: ["get", "watch", "list"] | ||
| - apiGroups: ["apps"] | ||
| resources: ["replicasets"] | ||
| verbs: ["get", "list", "watch"] | ||
| - apiGroups: ["extensions"] | ||
| resources: ["replicasets"] | ||
| verbs: ["get", "list", "watch"] | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRoleBinding | ||
| metadata: | ||
| name: opentelemetry-collector | ||
| labels: | ||
| app.kubernetes.io/name: google-built-opentelemetry-collector | ||
| app.kubernetes.io/version: "0.131.0" | ||
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: ClusterRole | ||
| name: opentelemetry-collector | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: opentelemetry-collector | ||
| namespace: opentelemetry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Copyright 2024 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: opentelemetry-collector | ||
| namespace: opentelemetry | ||
| labels: | ||
| app: opentelemetry-collector | ||
| spec: | ||
| type: ClusterIP | ||
| selector: | ||
| app: opentelemetry-collector | ||
| internalTrafficPolicy: Cluster | ||
| trafficDistribution: PreferClose | ||
| ports: | ||
| - name: otel-grpc | ||
| protocol: TCP | ||
| port: 4317 | ||
| targetPort: 4317 | ||
| - name: otlp-http | ||
| port: 4318 | ||
| targetPort: 4318 | ||
| protocol: TCP |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably a good option for some users, but i'm not sure we want to document this as a best-practice for everyone. I realized this means it won't distribute traffic equally cluster-wide anymore: https://kubernetes.io/docs/reference/networking/virtual-ips/#considerations-for-using-traffic-distribution-control. HPA scaling won't interact properly with this because traffic will still prefer a node-local collector, even if that collector is overloaded and others are underutilized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer zonal might make sense, but that also assumes that traffic is distributed equally across zones. I wonder if HPA can independently scale the deployment in each zone to match the zonal traffic...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can change the HPA to scale zonally also. I believe that a multizone GKE cluster would be the standard for most installations, however I can be wrong about this. This configuration has a preference for the zone communication and should work with a single zone. The equal distribution of traffic is also a standard, to my knowledge. However, we can also add these configurations as an overlay.