Skip to content

Conversation

@braydonk
Copy link
Contributor

@braydonk braydonk commented Sep 8, 2025

Description

This PR enables service attributes in the OTLP pipeline. It does this by enabling the field in the non-system googlecloudexporter pipeline, but strips away the resource attributes from all third-party app pipelines. This should allow us to update the service attribute expectations one 3P app at a time, while fixing the problem for the googlecloudmonitoring OTLP pipeline.

Related issue

b/438861396

How has this been tested?

The integration tests in this PR will be the main test other than unit and golden tests.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@braydonk braydonk changed the title [DO NOT MERGE YET] Enable service attributes Enable service attributes Sep 9, 2025
@braydonk braydonk changed the title Enable service attributes Enable service attributes in the OTLP googlecloudmonitoring pipeline Sep 9, 2025
@braydonk
Copy link
Contributor Author

braydonk commented Sep 9, 2025

I didn't set to draft before because I wanted the GitHub Actions to run. Consider this me manually considering this "out of draft" and ready for review.

Copy link
Member

@jefferbrecht jefferbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the tests pass

@braydonk
Copy link
Contributor Author

The only failed workflow was a quota issue. Merging.

@jefferbrecht
Copy link
Member

Test failures are unrelated; merging

@jefferbrecht jefferbrecht merged commit 8bc6870 into master Sep 23, 2025
60 of 62 checks passed
@jefferbrecht jefferbrecht deleted the remove_service_labels_from_3p branch September 23, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants