-
Notifications
You must be signed in to change notification settings - Fork 80
Enable service attributes in the OTLP googlecloudmonitoring pipeline #2059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
jefferbrecht
reviewed
Sep 8, 2025
Contributor
Author
|
I didn't set to draft before because I wanted the GitHub Actions to run. Consider this me manually considering this "out of draft" and ready for review. |
jefferbrecht
reviewed
Sep 9, 2025
jefferbrecht
approved these changes
Sep 9, 2025
jefferbrecht
reviewed
Sep 9, 2025
jefferbrecht
approved these changes
Sep 17, 2025
Member
jefferbrecht
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming the tests pass
jefferbrecht
approved these changes
Sep 17, 2025
Contributor
Author
|
The only failed workflow was a quota issue. Merging. |
Member
|
Test failures are unrelated; merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables service attributes in the OTLP pipeline. It does this by enabling the field in the non-system
googlecloudexporterpipeline, but strips away the resource attributes from all third-party app pipelines. This should allow us to update the service attribute expectations one 3P app at a time, while fixing the problem for thegooglecloudmonitoringOTLP pipeline.Related issue
b/438861396
How has this been tested?
The integration tests in this PR will be the main test other than unit and golden tests.
Checklist: