-
Notifications
You must be signed in to change notification settings - Fork 80
feat: Update Couchbase parsers to use LoggingReceiverMacro
#2043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dyl10s
wants to merge
19
commits into
GoogleCloudPlatform:master
Choose a base branch
from
dyl10s:feat/couchbase-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d71313e
created golden files
dyl10s 14eb829
initial implementation
dyl10s 271083d
realistic http access logs
dyl10s e88ab8e
realistic goxcdr logs
dyl10s 40e5b5c
golden files update
dyl10s 07f1081
removed undeeded code
dyl10s f2bb3dc
Merge remote-tracking branch 'origin/master' into feat/couchbase-refa…
dyl10s 30f8885
added new line to input.log
dyl10s b5c2b0d
Merge remote-tracking branch 'origin/master' into feat/couchbase-refa…
dyl10s 05a9597
Merge remote-tracking branch 'origin/master' into feat/couchbase-refa…
dyl10s 9d53e09
Merge remote-tracking branch 'origin/master' into feat/couchbase-refa…
dyl10s 1b17692
updated regex to correctly capture multiline
dyl10s 42ef74b
update golden files
dyl10s c3880de
Merge branch 'master' into feat/couchbase-refactor
dyl10s 1ff0392
Merge branch 'master' into feat/couchbase-refactor
dyl10s 17afe1e
Merge remote-tracking branch 'origin' into feat/couchbase-refactor
dyl10s 3ba843b
Merge branch 'master' into feat/couchbase-refactor
franciscovalentecastro 3179a55
Update confgenerator goldens.
franciscovalentecastro d75fcc0
Update transformation test goldens.
franciscovalentecastro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re @dyl10s :
What is the reason that
[\s|\S]fixes the regex for multiline parsing ? Is this specific thing for couchbase logs (e.g. trailing whitespace) ?