Skip to content

Conversation

@psx95
Copy link
Contributor

@psx95 psx95 commented Jul 9, 2025

No description provided.

@psx95 psx95 force-pushed the otlp-trace-collector branch from e5b711f to b57f0fc Compare July 9, 2025 21:18
@psx95 psx95 marked this pull request as ready for review July 10, 2025 14:13
@psx95 psx95 requested a review from a team as a code owner July 10, 2025 14:13
Comment on lines +62 to +65
$ ./deployment/run_collector.sh ./deployment/config.yaml
// From a separate terminal window - build & run the application
$ go build -o otlp_trace_collector
$ ./otlp_trace_collector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt of using docker compose instead of shell script and two terminals? It can also manage the build steps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll use docker-compose. Don't have a good reason for the script other than the fact that it was mostly copy-paste from other sample.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants