Skip to content

Conversation

@okvidhi
Copy link

@okvidhi okvidhi commented Jan 8, 2026

This PR introduces support for the google_dataplex_data_product resource in the google-beta provider.

Key features include:

  • Full CRUD Lifecycle: Verified support for creating, reading, updating, and deleting Data Products.
  • In-place Updates: Modifications to metadata and access_groups correctly trigger PATCH requests (UpdateDataProduct), allowing for zero-downtime updates.
  • LRO Polling: Implemented asynchronous polling to ensure Terraform waits for the long-running backend task to complete before reporting success.
`google_dataplex_data_product`

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 8, 2026
@github-actions github-actions bot requested a review from c2thorn January 8, 2026 08:28
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/dataplex and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 8, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 242 insertions(+))
google-beta provider: Diff ( 6 files changed, 1560 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 252 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 75
Passed tests: 73
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexDataProduct_dataplexDataProductBasicExample
  • TestAccDataplexDataProduct_dataplexDataProductFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataplexDataProduct_dataplexDataProductBasicExample [Debug log]
TestAccDataplexDataProduct_dataplexDataProductFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants