Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gemma finetune on GPU single node code, dockerfile and kubernetes manifest #1296

Merged
merged 5 commits into from
May 22, 2024

Conversation

moficodes
Copy link
Collaborator

Description

This PR add the python code, Dockerfile and Kubernetes manifests for Finetuning Gemma on GKE with multiple GPUs on a single Node.

Tasks

  • The contributing guide has been read and followed.
  • The samples added / modified have been fully tested.
  • Workflow files have been added / modified, if applicable.
  • Region tags have been properly added, if new samples.
  • All dependencies are set to up-to-date versions, as applicable.

@moficodes moficodes requested review from alizaidis, yoshi-approver and a team as code owners May 21, 2024 18:53
Copy link

snippet-bot bot commented May 21, 2024

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@moficodes
Copy link
Collaborator Author

@bourgeoisor

Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small things, the rest looks good

@moficodes
Copy link
Collaborator Author

/retest

@moficodes moficodes enabled auto-merge (squash) May 22, 2024 14:44
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moficodes moficodes merged commit f11028f into GoogleCloudPlatform:main May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants