feat(task): add task description label and WithTaskDescription option - #985
Merged
Merged
Conversation
kyasbal
added
area:backend-core
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new task label, LabelKeyTaskDescription, to support human-readable descriptions for tasks, and integrates it across various task and form implementations. The review feedback suggests simplifying the implementation of WithTaskDescription by reusing the existing WithLabelValue helper instead of defining a custom struct.
Merged
via the queue into
GoogleCloudPlatform:main
with commit Sep 11, 2026
52cb728
17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
LabelKeyTaskDescriptiontopkg/core/taskalong withWithTaskDescriptionlabel option to attach human-readable descriptions to inspection tasks.Details
LabelKeyTaskDescriptioninpkg/core/task/task.go.WithTaskDescriptionand its implementation inpkg/core/task/label.go.TestWithTaskDescriptioninpkg/core/task/label_test.go.DefaultK8sResourceMergeConfigTask.LabelKeyTaskDescriptioninpkg/task/inspection/inspectioncore/contract.