Skip to content

chore: merge main into epic/task-system-v3 - #984

Merged
kyasbal merged 11 commits into
GoogleCloudPlatform:epic/task-system-v3from
kyasbal:push-upzlnqnvzqtx
Sep 11, 2026
Merged

chore: merge main into epic/task-system-v3#984
kyasbal merged 11 commits into
GoogleCloudPlatform:epic/task-system-v3from
kyasbal:push-upzlnqnvzqtx

Conversation

@kyasbal

@kyasbal kyasbal commented Sep 11, 2026

Copy link
Copy Markdown
Member

Merges the latest changes from main into epic/task-system-v3.

kyasbal and others added 11 commits September 8, 2026 03:48
…tform#971)

* chore(github): reorganize issue and PR label taxonomy

Reorganize GitHub issue and PR label system to improve discoverability,
triage ergonomics, and release automation alignment:
- Update .github/release.yml changelog categories to use new label names (type:feature, type:bug, type:perf, type:refactor, area:cicd, area:devenv, type:docs, type:chore).
- Configure .github/ISSUE_TEMPLATE/bug-report.md with default labels "type:bug, status:needs-triage".
- Configure .github/ISSUE_TEMPLATE/feature-request.md with default labels "type:feature, status:needs-triage".

* fix(github): separate maintenance and dependencies categories in release notes
…mmaries (GoogleCloudPlatform#973)

* feat(k8sevent): replace resource UIDs with readable names in event summaries

- Add ResourceIdentity.SummaryTag() method to format resources as readable tags
- Replace matched resource UIDs in Kubernetes event messages with readable tags in both GKE and OSS log ingesters
- Map matched resource UIDs to corresponding resource timelines in ProcessLogByGroup
- Add HasEventCount assertion helper to TimelineChangeSetAsserter

* fix(review): address review comments on deduplicating formatEventSummary and HasEventCount
…-coding-rule (GoogleCloudPlatform#974)

* docs(agent): clarify cmp.Diff usage and test assertion examples in go-coding-rule

* fix(agent): address review comments on collections comparison in go-coding-rule
…oogleCloudPlatform#977)

* feat(timeline): allow inline editing of search filter chips on click

Enable in-place editing of search filter chips in ChipSearchBarComponent
when clicked. Clicking a chip renders an inline text input with text
pre-selected and auto-focused. Changes can be committed with Enter or blur,
or cancelled with Escape. Delimiter splitting and whitespace removal are
supported.

* fix(review): address review comments on blur race condition and focus preservation
…to timezoneShiftHours (GoogleCloudPlatform#978)

Following the Connect-RPC migration (GoogleCloudPlatform#908), the timezone shift parameter
was updated in Protobuf and backend RPC handlers to timezoneShiftHours
(float64). However, TimeZoneShiftInputTask and the frontend InspectionClient
retained references to the legacy timezoneShift key, causing inspections
to always fall back to UTC time.

This change:
- Unifies the context key to TaskInputKeyTimezoneShiftHours in inspectioncore
- Updates TimeZoneShiftInputTask to read TaskInputKeyTimezoneShiftHours
- Updates backend-api.service.ts and its test to use timezoneShiftHours
- Updates parser_test.go to float64(9)
- Adds unit tests for TimeZoneShiftInputTask
…ogs (GoogleCloudPlatform#979)

* fix(k8saudit): preserve immutable identity metadata after truncated logs

When Kubernetes audit logs contain truncated responses (audit.k8s.io/truncated: "true"),
groupManifestGenerator reset prevRevisionReader to nil. Subsequent patch requests merged
into an empty map reader, causing metadata.uid to be lost. Later tasks interpreted the
missing UID as a new resource creation, incorrectly emitting a ChangeEventTypeCreation
event and overwriting the initial revision at creationTimestamp.

This commit updates manifest_generator_task to preserve immutable identity metadata
(apiVersion, kind, metadata.name, metadata.namespace, metadata.uid, metadata.creationTimestamp)
upon encountering truncated logs so that subsequent patches retain the resource identity.

* fix(k8saudit): return preserved immutable identity reader for truncated log body

When a log is truncated, groupManifestGenerator now returns the preserved immutable
identity reader as ResourceBodyReader rather than nil. This allows the truncated log
itself to retain its immutable identity metadata in the generated timeline revision,
preventing the resource body from appearing completely empty in the UI and downstream
tasks.
…low_dispatch (GoogleCloudPlatform#980)

* feat(cicd): support manual tag creation and release draft generation via workflow_dispatch

Add a workflow_dispatch trigger to .github/workflows/release.yaml, allowing
maintainers to initiate tag creation and release draft generation directly from
the GitHub Actions Web UI without local terminal operations.

- Accept a required tag_name input parameter (e.g., v1.2.3 or v1.2.3-beta-1)
- Validate tag format and verify uniqueness via git ls-remote before starting builds
- Create and push the Git tag after successful binary compilation
- Automatically generate release notes from categorised commit history

* fix(cicd): pass step outputs via env to prevent template injection
…ctionTypeLabel (GoogleCloudPlatform#981)

Remove deprecated LabelKeyInspectionTypes, InspectionTypeLabel, and
legacy fallback logic from inspection runner. Update tests and
documentation to use InspectionTypeLabelSelector.
…leCloudPlatform#982)

Add WithDefaultValueFunc to InputComposerEnvironmentNameTask so that
when Composer environments are fetched via autocomplete, the first
environment is automatically selected as the default value if no
previous selection was made.
@kyasbal kyasbal added area:backend-core Core backend frameworks, DAG task runner, and server API area:backend-parser Log parsers and log timeline mapper tasks type:chore Maintenance, dependency updates, and tooling chores labels Sep 11, 2026
@kyasbal
kyasbal merged commit ac9e62e into GoogleCloudPlatform:epic/task-system-v3 Sep 11, 2026
9 checks passed
@kyasbal
kyasbal deleted the push-upzlnqnvzqtx branch September 11, 2026 06:45

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces legacy task label selectors with InspectionTypeLabelSelector, refactors task compatibility checks, and updates documentation accordingly. It also introduces resource identity preservation for truncated audit logs, adds default value handling for the Composer environment name task, updates the default Kubernetes resource kind filter, and renames the timezone shift parameter to timezoneShiftHours. On the frontend, it adds inline editing capabilities for search chips in the search bar. Feedback on the changes highlights two potential nil pointer dereference panics: one in extractResourceIdentity if prevRevision is nil, and another in the Composer environment name task's default value function if the autocomplete result is nil.

Comment on lines +312 to +313
func extractResourceIdentity(store *structured.LazyJSONBlockStore, prevRevision *structured.NodeReader) *structured.NodeReader {
apiVersion := prevRevision.ReadStringOrDefault(pathAPIVersion, "")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If prevRevision is nil, calling prevRevision.ReadStringOrDefault will result in a nil pointer dereference panic. Add a defensive nil check at the beginning of extractResourceIdentity to safely handle nil inputs.

Suggested change
func extractResourceIdentity(store *structured.LazyJSONBlockStore, prevRevision *structured.NodeReader) *structured.NodeReader {
apiVersion := prevRevision.ReadStringOrDefault(pathAPIVersion, "")
func extractResourceIdentity(store *structured.LazyJSONBlockStore, prevRevision *structured.NodeReader) *structured.NodeReader {
if prevRevision == nil {
return structured.NewNodeReader(structured.NewEmptyMapNode())
}
apiVersion := prevRevision.ReadStringOrDefault(pathAPIVersion, "")

Comment on lines +31 to +33
).WithDefaultValueFunc(func(ctx context.Context, previousValues []string) (string, error) {
environments := coretask.GetTaskResult(ctx, googlecloudclustercomposer_contract.AutocompleteComposerEnvironmentIdentityTaskID.Ref())
if len(previousValues) > 0 && slices.ContainsFunc(environments.Values, func(env googlecloudclustercomposer_contract.ComposerEnvironmentIdentity) bool {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If the autocomplete task fails and returns a nil result, calling environments.Values will cause a nil pointer dereference panic. Add a defensive nil check for environments before accessing its fields.

).WithDefaultValueFunc(func(ctx context.Context, previousValues []string) (string, error) {
	environments := coretask.GetTaskResult(ctx, googlecloudclustercomposer_contract.AutocompleteComposerEnvironmentIdentityTaskID.Ref())
	if environments == nil {
		return "", nil
	}
	if len(previousValues) > 0 && slices.ContainsFunc(environments.Values, func(env googlecloudclustercomposer_contract.ComposerEnvironmentIdentity) bool {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend-core Core backend frameworks, DAG task runner, and server API area:backend-parser Log parsers and log timeline mapper tasks type:chore Maintenance, dependency updates, and tooling chores

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants