Merge pull request #102 from nikhiljindal/fixSSLBug

Fixing a bug in deleting SSL certs
GoogleCloudPlatform · Dec 13, 2017 · 21b3b39 · 21b3b39
2 parents 86a0da1 + f249f49
commit 21b3b39
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/app/kubemci/pkg/gcp/loadbalancer/loadbalancersyncer.go b/app/kubemci/pkg/gcp/loadbalancer/loadbalancersyncer.go
@@ -224,14 +224,14 @@ func (l *LoadBalancerSyncer) DeleteLoadBalancer(ing *v1beta1.Ingress) error {
 		// Aggregate errors and return all at the end.
 		err = multierror.Append(err, frErr)
 	}
-	if scErr := l.scs.DeleteSSLCert(); scErr != nil {
-		// Aggregate errors and return all at the end.
-		err = multierror.Append(err, scErr)
-	}
 	if tpErr := l.tps.DeleteTargetProxies(); tpErr != nil {
 		// Aggregate errors and return all at the end.
 		err = multierror.Append(err, tpErr)
 	}
+	if scErr := l.scs.DeleteSSLCert(); scErr != nil {
+		// Aggregate errors and return all at the end.
+		err = multierror.Append(err, scErr)
+	}
 	if umErr := l.ums.DeleteURLMap(); umErr != nil {
 		// Aggregate errors and return all at the end.
 		err = multierror.Append(err, umErr)