Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency gunicorn to v23 #1590

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
gunicorn (changelog) ==22.0.0 -> ==23.0.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Release Notes

benoitc/gunicorn (gunicorn)

v23.0.0

Compare Source

Gunicorn 23.0.0 has been released. This version improve HTTP 1.1. support and which improve safety

You're invited to upgrade asap your own installation.

23.0.0 - 2024-08-10

  • minor docs fixes (:pr:3217, :pr:3089, :pr:3167)
  • worker_class parameter accepts a class (:pr:3079)
  • fix deadlock if request terminated during chunked parsing (:pr:2688)
  • permit receiving Transfer-Encodings: compress, deflate, gzip (:pr:3261)
  • permit Transfer-Encoding headers specifying multiple encodings. note: no parameters, still (:pr:3261)
  • sdist generation now explicitly excludes sphinx build folder (:pr:3257)
  • decode bytes-typed status (as can be passed by gevent) as utf-8 instead of raising TypeError (:pr:2336)
  • raise correct Exception when encounting invalid chunked requests (:pr:3258)
  • the SCRIPT_NAME and PATH_INFO headers, when received from allowed forwarders, are no longer restricted for containing an underscore (:pr:3192)
  • include IPv6 loopback address [::1] in default for :ref:forwarded-allow-ips and :ref:proxy-allow-ips (:pr:3192)

** NOTE **

  • The SCRIPT_NAME change mitigates a regression that appeared first in the 22.0.0 release
  • Review your :ref:forwarded-allow-ips setting if you are still not seeing the SCRIPT_NAME transmitted
  • Review your :ref:forwarder-headers setting if you are missing headers after upgrading from a version prior to 22.0.0

** Breaking changes **

  • refuse requests where the uri field is empty (:pr:3255)
  • refuse requests with invalid CR/LR/NUL in heade field values (:pr:3253)
  • remove temporary --tolerate-dangerous-framing switch from 22.0 (:pr:3260)
  • If any of the breaking changes affect you, be aware that now refused requests can post a security problem, especially so in setups involving request pipe-lining and/or proxies.

Fix CVE-2024-1135


Configuration

📅 Schedule: Branch creation - "* * 1 */3 *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled because a matching PR was automerged previously.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested a review from a team as a code owner January 1, 2025 20:20
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will have a full review ready in a few minutes. In the meantime, here's a quick summary to get everyone up to speed:

This pull request, submitted by Renovate Bot, updates the gunicorn dependency across the project from version 22.0.0 to 23.0.0. The primary intent is to keep our dependencies current, leveraging the latest bug fixes and improvements offered in the newer version. The changelog highlights several bug fixes, including improvements to HTTP 1.1 support and addressing a potential deadlock issue. There are also some breaking changes noted, so careful review of those is recommended.

The key change is reflected in the requirements.txt file within the gemini/sample-apps/gemini-mesop-cloudrun directory. Specifically, line 3 of this file has been updated to reflect the new version:

- gunicorn==22.0.0
+ gunicorn==23.0.0

I'll be checking for any potential conflicts or regressions introduced by this update in my full review.


A little poem for your enjoyment:

Dependency's call,
Version numbers rise and fall,
Update, keep it safe.

Best,
Gemini

Copy link
Contributor

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will have a full review up in a few minutes. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request, submitted by Renovate Bot, updates the gunicorn dependency across the project from version 22.0.0 to 23.0.0. The primary intent is to keep our dependencies current, leveraging the latest bug fixes and improvements offered in the newer version. The gunicorn 23.0.0 release includes several bug fixes, improved HTTP 1.1 support, and some breaking changes related to request validation (rejecting requests with empty URIs or invalid characters in headers). These changes enhance security and stability.

The key change is reflected in the requirements.txt file within the gemini/sample-apps/gemini-mesop-cloudrun directory. Specifically, line 3 of this file has been updated to reflect the new version:

- gunicorn==22.0.0
+ gunicorn==23.0.0

It's important to note that the release notes mention some breaking changes, so ensure your application is compatible with these updates. Pay close attention to the notes regarding forwarded-allow-ips and forwarder-headers if you are using those configurations.

Now for a little fun:

A simple change,
Quick update, clean and bright,
Code's future shines.

Let me know if you have any questions.

Best,
Gemini

Copy link
Contributor

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will have a full review for you in a few minutes. In the meantime, here's a quick summary to get everyone up to speed:

This pull request, submitted by Renovate Bot, updates the gunicorn dependency across the project from version 22.0.0 to 23.0.0. The primary intent is to keep our dependencies current, leveraging the latest bug fixes and improvements. The changelog highlights several improvements, including enhanced HTTP 1.1 support, deadlock fixes, and improved handling of various header encodings. There are also some noted breaking changes, so careful review of those is recommended.

The key change is reflected in the requirements.txt file within the gemini/sample-apps/gemini-mesop-cloudrun directory. Specifically, line 3 of this file has been modified to reflect the updated version number:

- gunicorn==22.0.0
+ gunicorn==23.0.0

I'll be checking for any potential conflicts or regressions introduced by this update in my full review.


A little poem to brighten your day:

Update the code,
Fix the bugs, make it shine,
Fresh version's delight.

Best,
Gemini

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the gunicorn dependency to version 23.0.0. It's good practice to keep dependencies up-to-date, and the changelog indicates improvements to HTTP 1.1 support and security fixes, including a CVE patch. Before merging, it's recommended to test the application thoroughly to ensure compatibility with the new version and that no regressions have been introduced.

The provided release notes are helpful, and the PR description is well-formatted thanks to Renovate. I've added the breaking changes from this version upgrade to the README file to inform users of potential impacts. I also added a note to the instructions in the README file to pin gunicorn to a major version to avoid unexpected breaking changes in the future.

Copy link
Contributor

@ghchinoy ghchinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants