-
Notifications
You must be signed in to change notification settings - Fork 473
chore(deps): go sdk mrd changes #4253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore(deps): go sdk mrd changes #4253
Conversation
Summary of ChangesHello @krishnamd-jkp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the Go SDK's dependencies to align with new Minimum Required Dependencies (MRD). Specifically, it bumps the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the cloud.google.com/go/storage dependency to a pre-release version, likely to incorporate upcoming Multi-Range Downloader (MRD) changes. While this may be a necessary step, using an untagged pre-release dependency introduces potential stability risks, especially since the PR description indicates no new tests were added. My review includes a comment on go.mod highlighting this concern.
| cloud.google.com/go/profiler v0.4.3 | ||
| cloud.google.com/go/secretmanager v1.16.0 | ||
| cloud.google.com/go/storage v1.58.0 | ||
| cloud.google.com/go/storage v1.58.1-0.20260107200059-8f90da38abc6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change updates cloud.google.com/go/storage to a pre-release pseudo-version (v1.58.1-0.20260107200059-8f90da38abc6). Using untagged, pre-release dependencies can be risky as they may point to unstable or unvetted code. The PR description also indicates that no unit or integration tests were run for this change, which increases the risk of introducing regressions.
It is recommended to use a stable, tagged release of this dependency. If this specific commit is required for the upcoming MRD changes, it should be validated in a separate environment before being merged into the main branch.
Description
Pre-release PR for go SDK's MRD changes
Link to the issue in case of a bug fix.
Testing details
Any backward incompatible change? If so, please explain.