add go-storage tests to npi.py #79
Conversation
Summary of ChangesHello @PranjalC100, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the NPI benchmarking suite by adding Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new go-storage-tests benchmark, including a new Docker image, a Python script for orchestration, and updates to the build and main runner scripts. The implementation is mostly sound, but I've identified a critical issue regarding a dependency on a personal GitHub repository, which presents a security and maintenance risk. I have also provided several suggestions to improve the robustness and style of the new Python benchmark script, such as using the tempfile module for temporary directories and making benchmark output parsing less fragile.
|
|
||
| FROM golang:${GO_VERSION} AS builder | ||
| WORKDIR /app | ||
| RUN git clone https://github.com/kislaykishore/custom-go-client-benchmark.git |
There was a problem hiding this comment.
The Dockerfile clones a repository from a personal GitHub account (https://github.com/kislaykishore/custom-go-client-benchmark.git). This introduces a significant security and maintenance risk, as the repository is not under the control of the project maintainers. It could be removed, altered with breaking changes, or compromised with malicious code at any time. It is strongly recommended to either vendor this dependency or fork it into a repository controlled by your organization.
| # run_tests will handle the path. We just need to make sure permissions are executable. | ||
| # Docker COPY usually preserves permissions or we can chmod. | ||
| else: | ||
| repo_url = "https://github.com/kislaykishore/custom-go-client-benchmark" |
There was a problem hiding this comment.
The script is configured to clone a benchmark tool from a personal GitHub repository (https://github.com/kislaykishore/custom-go-client-benchmark). This is a significant security and reliability risk because the repository is not controlled by the project. The code could be modified with breaking changes, become unavailable, or even be compromised with malicious code. To ensure the security and stability of your build process, this dependency should be vendored or moved to a repository under your organization's control.
1 participant
Adding Go-storage-tests to NPI framework. This will help us test the performance of Go SDK on the machine in isolation i.e. no GCSFuse involvement.
How to run:
https://buganizer.corp.google.com/issues/474254631