Skip to content

Update Go version to 1.24.11 in Makefile #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seonjunmoon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Go version to 1.24.11 in Makefile #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion npi/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

GCSFUSE_VERSION ?= v3.4.0
GO_VERSION=1.24.5
GO_VERSION=1.24.11
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating the Go version here is correct. However, this version number is now inconsistent with other parts of the codebase, which can cause confusion and maintenance issues.

  • npi/cloudbuild.yaml specifies a default _GO_VERSION of 1.25.0.
  • Several Dockerfiles (e.g., npi/gcsfuse-perf-base.dockerfile, and others in npi/fio/) specify a default GO_VERSION of 1.24.5.

While this Makefile overrides these values during the make build process, it's best practice to update these other files to use 1.24.11 for consistency. This would prevent accidental use of an old version if builds are run through other means.

UBUNTU_VERSION=24.04
REGISTRY=us-docker.pkg.dev
PROJECT=gcs-fuse-test
Expand Down