Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helloworld-shell/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# Use the offical golang image to create a binary.
# This is based on Debian and sets the GOPATH to /go.
# https://hub.docker.com/_/golang
FROM golang:1.25-trixie as builder
FROM golang:1.26-trixie as builder

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the Go version in the build environment is being updated to 1.26, the corresponding go.mod file (helloworld-shell/go.mod) still specifies go 1.19. It is a best practice to align the Go version in your go.mod file with the toolchain version you are using for building. This ensures compatibility, allows the project to utilize new language features and improvements, and makes the project's requirements explicit. Please consider updating the go directive in helloworld-shell/go.mod to go 1.26.


# Create and change to the app directory.
WORKDIR /app
Expand Down
2 changes: 1 addition & 1 deletion testing/test-cases/module.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang:1.25 as builder
FROM golang:1.26 as builder

WORKDIR /app

Expand Down