fix: Report billing attachment errors#120
Draft
saraford wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Draft
fix: Report billing attachment errors#120saraford wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
saraford wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
The create_project tool previously returned a generic success message even if attaching the billing account failed. This change modifies the tool to return the detailed billing message from the underlying function, ensuring the user is correctly informed of the full status of the project creation.
Updates the local unit tests and the GCP integration test to correctly handle and verify the new conditional logic for reporting billing attachment status. - The local unit test now has distinct cases for success and warning messages. - The GCP integration test now asserts that the billing warning is correctly received.
Collaborator
Author
|
I was only able to manually test for a project that didn't get billing enabled. We'll need to verify this fix also works with the happy path where a project is created with billing enabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The create_project tool previously returned a generic success message even if attaching the billing account failed.
This change modifies the tool to return the detailed billing message from the underlying function, ensuring the user is correctly informed of the full status of the project creation.
Here's what the interaction with the agent looks like: