Skip to content

Improve error messages in packageupgrade_test.go. The error messages for failed package installations now include both stdout and stderr from the command execution, providing more context for debugging. #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jan 9, 2026
+15 −15
Merged

Improve error messages in packageupgrade_test.go. The error messages for failed package installations now include both stdout and stderr from the command execution, providing more context for debugging. #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions test_suites/packageupgrade/packageupgrade_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func VerifyInstallReturn(t *testing.T, pkg string, input string) {
if matchedInstall || matchedNoaction {
return
}
t.Fatalf("Installation of '%s' returned unexpected result: %s", pkg, input)
t.Fatalf("Installation of %q returned unexpected result: %s", pkg, input)
}

func TestPvpanicDriverInstallFromTesting(t *testing.T) {
Expand All @@ -73,7 +73,7 @@ func TestPvpanicDriverInstallFromTesting(t *testing.T) {
command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)
output, err := utils.RunPowershellCmd(command)
if err != nil {
t.Fatalf("Error installing '%s': %v", driver, output.Stdout)
t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)
}
VerifyInstallReturn(t, driver, output.Stdout)
}
Expand All @@ -86,7 +86,7 @@ func TestGgaDriverInstallFromTesting(t *testing.T) {
command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)
output, err := utils.RunPowershellCmd(command)
if err != nil {
t.Fatalf("Error installing '%s': %v", driver, output.Stdout)
t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)
}
VerifyInstallReturn(t, driver, output.Stdout)
}
Expand All @@ -99,7 +99,7 @@ func TestBalloonDriverInstallFromTesting(t *testing.T) {
command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)
output, err := utils.RunPowershellCmd(command)
if err != nil {
t.Fatalf("Error installing '%s': %v", driver, output.Stdout)
t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)
}
VerifyInstallReturn(t, driver, output.Stdout)
}
Expand All @@ -112,7 +112,7 @@ func TestGvnicDriverInstallFromTesting(t *testing.T) {
command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)
output, err := utils.RunPowershellCmd(command)
if err != nil {
t.Fatalf("Error installing '%s': %v", driver, output.Stdout)
t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)
}
VerifyInstallReturn(t, driver, output.Stdout)
}
Expand All @@ -125,7 +125,7 @@ func TestNetkvmDriverInstallFromTesting(t *testing.T) {
command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)
output, err := utils.RunPowershellCmd(command)
if err != nil {
t.Fatalf("Error installing '%s': %v", driver, output.Stdout)
t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)
}
VerifyInstallReturn(t, driver, output.Stdout)
}
Expand All @@ -138,7 +138,7 @@ func TestVioscsiDriverInstallFromTesting(t *testing.T) {
command := fmt.Sprintf("%s -noconfirm install %s", googet, driver)
output, err := utils.RunPowershellCmd(command)
if err != nil {
t.Fatalf("Error installing '%s': %v", driver, output.Stdout)
t.Fatalf("Error installing %q: stdout: %s, stderr: %s", driver, output.Stdout, output.Stderr)
}
VerifyInstallReturn(t, driver, output.Stdout)
}
Expand All @@ -151,7 +151,7 @@ func TestCertgenPackageInstallFromTesting(t *testing.T) {
command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)
output, err := utils.RunPowershellCmd(command)
if err != nil {
t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)
t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)
}
VerifyInstallReturn(t, pkg, output.Stdout)
}
Expand All @@ -164,7 +164,7 @@ func TestGoogetPackageInstallFromTesting(t *testing.T) {
command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)
output, err := utils.RunPowershellCmd(command)
if err != nil {
t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)
t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)
}
VerifyInstallReturn(t, pkg, output.Stdout)
}
Expand All @@ -177,7 +177,7 @@ func TestGceDiagnosticsPackageInstallFromTesting(t *testing.T) {
command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)
output, err := utils.RunPowershellCmd(command)
if err != nil {
t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)
t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)
}
VerifyInstallReturn(t, pkg, output.Stdout)
}
Expand All @@ -190,7 +190,7 @@ func TestGceMetadataScriptsPackageInstallFromTesting(t *testing.T) {
command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)
output, err := utils.RunPowershellCmd(command)
if err != nil {
t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)
t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)
}
VerifyInstallReturn(t, pkg, output.Stdout)
}
Expand All @@ -203,7 +203,7 @@ func TestGcePowershellPackageInstallFromTesting(t *testing.T) {
command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)
output, err := utils.RunPowershellCmd(command)
if err != nil {
t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)
t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)
}
VerifyInstallReturn(t, pkg, output.Stdout)
}
Expand All @@ -216,7 +216,7 @@ func TestGceSysprepPackageInstallFromTesting(t *testing.T) {
command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)
output, err := utils.RunPowershellCmd(command)
if err != nil {
t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)
t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)
}
VerifyInstallReturn(t, pkg, output.Stdout)
}
Expand All @@ -229,7 +229,7 @@ func TestWindowsGuestAgentInstallFromTesting(t *testing.T) {
command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)
output, err := utils.RunPowershellCmd(command)
if err != nil {
t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)
t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)
}
VerifyInstallReturn(t, pkg, output.Stdout)
}
Expand All @@ -242,7 +242,7 @@ func TestOSConfigAgentInstallFromTesting(t *testing.T) {
command := fmt.Sprintf("%s -noconfirm install %s", googet, pkg)
output, err := utils.RunPowershellCmd(command)
if err != nil {
t.Fatalf("Error installing '%s': %v", pkg, output.Stdout)
t.Fatalf("Error installing %q: stdout: %s, stderr: %s", pkg, output.Stdout, output.Stderr)
}
VerifyInstallReturn(t, pkg, output.Stdout)
}