Feature/add precommit hook #6336
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add precommit pyink formatter
hubatish
approved these changes
Jan 7, 2026
Collaborator
|
Thanks for adding this! Hopefully it will work with our push/pull automation to copy commits to/from our internal repo. But in general this looks very useful for external contributors! |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
Copy of #6336 PR by kiryl-filatau There are also existing hooks in https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/tree/master/hooks ..but these look pretty ancient (last change 8 years ago). Will ignore for now & can potentially incorporate some of the useful features (like only running linter on modified files) in the future. PiperOrigin-RevId: 853328012
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
Copy of #6336 PR by kiryl-filatau There are also existing hooks in https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/tree/master/hooks ..but these look pretty ancient (last change 8 years ago). Will ignore for now & can potentially incorporate some of the useful features (like only running linter on modified files) in the future. PiperOrigin-RevId: 853836176
Collaborator
|
I committed #6342 as y'all didn't have permissions to create a new file in this folder. |
Collaborator
|
And for that reason I'm closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pre-commit hook