-
Notifications
You must be signed in to change notification settings - Fork 543
add aws support to ai-inference in pkb #6201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kiryl-filatau
wants to merge
4
commits into
GoogleCloudPlatform:master
Choose a base branch
from
kiryl-filatau:feature/add-aws-support-to-ai-inference-pkb
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7ed5fef
add aws support to ai-inference in pkb with temporary link to wg-serv…
kiryl-filatau 013cb43
Merge branch 'master' into feature/add-aws-support-to-ai-inference-pkb
kiryl-filatau b2c0067
added AWS-only condition for gpu nodepool manifest, moved wg-serving …
kiryl-filatau c2f11fc
move WG Serving repo flags to wg_serving_inference_server and use fla…
kiryl-filatau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
27 changes: 27 additions & 0 deletions
27
perfkitbenchmarker/data/container/kubernetes_ai_inference/aws-gpu-nodepool.yaml.j2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| apiVersion: karpenter.sh/v1 | ||
| kind: NodePool | ||
| metadata: | ||
| name: {{ gpu_nodepool_name | default('gpu') }} | ||
| spec: | ||
| disruption: | ||
| consolidateAfter: {{ gpu_consolidate_after | default('1h') }} | ||
| consolidationPolicy: {{ gpu_consolidation_policy | default('WhenEmpty') }} | ||
| template: | ||
| spec: | ||
| nodeClassRef: | ||
| group: eks.amazonaws.com | ||
| kind: NodeClass | ||
| name: {{ karpenter_nodeclass_name | default('default') }} | ||
| requirements: | ||
| - key: karpenter.sh/capacity-type | ||
| operator: In | ||
| values: {{ gpu_capacity_types | default(['on-demand']) }} | ||
| - key: kubernetes.io/arch | ||
| operator: In | ||
| values: {{ gpu_arch | default(['amd64']) }} | ||
| - key: eks.amazonaws.com/instance-family | ||
| operator: In | ||
| values: {{ gpu_instance_families | default(['g6','g6e']) }} | ||
| taints: | ||
| - key: {{ gpu_taint_key | default('nvidia.com/gpu') }} | ||
| effect: NoSchedule |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my end this looks merged in:
https://screenshot.googleplex.com/AREUuCaL76yAdQg
Ooh ok actually perhaps this has made it in but been superceded by follow up PRs? https://screenshot.googleplex.com/BNVuvNLwNKckBF5 is the current state of wg_serving_inference_server.py & it does have a cloud == 'AWS' section.
I suppose we simply close this PR?