Skip to content

Conversation

Csabesz07
Copy link

This feature lets the user further optimise the compression of the image by adding new options under oxipng.

  • The deflater of oxipng is now selectable (zopfli / libdeflater)
  • Both deflater's parameters are modifiable (iterations / compress level)

@jakearchibald
Copy link
Collaborator

This is exciting!

@surma
Copy link
Collaborator

surma commented Apr 22, 2024

@Csabesz07 Your code seems to be working :) If you compress a bigger image, the time it take to compress is hugely different although in this case, the compressed file size is almost identical, which is not completely unexpected :D

Screenshot 2024-04-22 at 09 00 01

I’ll do a review in a bit :)

@jakearchibald
Copy link
Collaborator

jakearchibald commented Apr 22, 2024

the time it take to compress is hugely different although in this case, the compressed file size is almost identical, which is not completely unexpected :D

I'm not seeing any difference when changing the deflater, or the iterations / compress level setting, which feels a bit sus

@Csabesz07
Copy link
Author

I'm not seeing any difference when changing the deflater, or the iterations / compress level setting, which feels a bit sus

Exactly! This is my concern as well, but the way I see, all options are being applied at the moment.
Oxipng documentation mentions that if any of the optimize's options's properties are defined manually, the initial preset options will be overriden with those.

@surma
Copy link
Collaborator

surma commented Apr 22, 2024

I rebuilt the codec locally when testing. I wonder if the binaries on the PR are outdated or something. I’ll take another look tomorrow at that.

@Csabesz07 Csabesz07 requested a review from surma September 7, 2025 18:11
@Csabesz07
Copy link
Author

Hi @surma
Sorry for the slow follow-up on your change requests. After a busy year, I’m back with full focus. If this feature is still useful for the project, I’d be happy to pick up where we left off and push it forward. What’s the best next step?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants