Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: split puppeteer tests into 4 shards #2893

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Dec 13, 2024

Brings total duration from 7m to 3m.

@OrKoN OrKoN added the puppeteer Run Puppeteer test when added to PR label Dec 13, 2024
@OrKoN OrKoN requested a review from sadym-chromium December 13, 2024 09:09
@OrKoN OrKoN marked this pull request as ready for review December 13, 2024 09:09
@OrKoN
Copy link
Collaborator Author

OrKoN commented Dec 13, 2024

The setup and builds seems to be expensive for the job, so perhaps it's not worth it, it saves about 2-3 minutes only.

@OrKoN
Copy link
Collaborator Author

OrKoN commented Dec 13, 2024

The setup and builds seems to be expensive for the job, so perhaps it's not worth it, it saves about 2-3 minutes only.

added wireit to see if it improves.

@OrKoN OrKoN force-pushed the orkon/puppeteer-sharding branch from daa8f1f to 145a50c Compare December 13, 2024 09:44
@OrKoN OrKoN force-pushed the orkon/puppeteer-sharding branch from 145a50c to b2a492d Compare December 13, 2024 09:57
@OrKoN OrKoN enabled auto-merge (squash) December 13, 2024 10:07
@OrKoN OrKoN merged commit 9308266 into main Dec 13, 2024
52 checks passed
@OrKoN OrKoN deleted the orkon/puppeteer-sharding branch December 13, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
puppeteer Run Puppeteer test when added to PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants