Skip to content

Conversation

maiconcarraro
Copy link

@maiconcarraro maiconcarraro commented Aug 6, 2024

@ibrahimkarahan I noticed the last checks are failing, and it could be the reason to not release a new version yet, so sending this PR to fix the tests and try to help release a new version soon - a lot of devs from PWABuilder will benefit from this.

Some tests are using mock-fs which has some incompatibility at the moment: tschaub/mock-fs#384 and that's the cause for these errors: https://github.com/GoogleChromeLabs/bubblewrap/actions/runs/9993866664/job/27622289533

Module mocking with jasmine is a little bit tricky, but very easy with jest, so while doing the replacement of mock-fs to memfs I also migrated to jest (and ts-jest), I know it can be controversial... I couldn't make it work well with jasmine... I did make sure to match the previous expected result, including the customization for some describe errors.

image

Before (from CI):
image

After:
image

Copy link

google-cla bot commented Aug 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant