refactor(gcpspanner): Migrate WebFeatureChromiumHistogramEnumValue to use Sync #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use Sync This commit refactors the handling of WebFeatureChromiumHistogramEnumValue entities to use the generic entitySynchronizer instead of manual upserts. The webFeaturesChromiumHistogramEnumSpannerMapper now implements the syncableEntityMapper interface, allowing for more robust and efficient batch synchronization. The ChromiumHistogramEnumsClient interface and its consumer have been updated to use the new SyncWebFeatureChromiumHistogramEnumValues method. This change simplifies the data ingestion logic for Chromium histogram enum mappings and aligns it with the project's standard data synchronization pattern. Fixes #1915
jcscottiii
force-pushed
the
jcscottiii/fix-1915
branch
from
e680157 to
9ceed55
Compare
jrobbins
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the handling of WebFeatureChromiumHistogramEnumValue entities to use the generic entitySynchronizer instead of manual upserts.
The webFeaturesChromiumHistogramEnumSpannerMapper now implements the syncableEntityMapper interface, allowing for more robust and efficient batch synchronization.
The ChromiumHistogramEnumsClient interface and its consumer have been updated to use the new SyncWebFeatureChromiumHistogramEnumValues method.
This change simplifies the data ingestion logic for Chromium histogram enum mappings and aligns it with the project's standard data synchronization pattern.
Fixes #1915