Skip to content

Continue when a workload is not working#113

Merged
rmahdav merged 11 commits intomainfrom
continue-when-a-workload-is-not-working
Mar 24, 2026
Merged

Continue when a workload is not working#113
rmahdav merged 11 commits intomainfrom
continue-when-a-workload-is-not-working

Conversation

@rmahdav
Copy link
Copy Markdown
Collaborator

@rmahdav rmahdav commented Feb 27, 2026

This PR fixes issue #82.

If a workload throws an error (during initialization or running), we show a warning on the result page and notify the user. I have tested the following situations:

  1. A number of workloads throw error in each iteration. The list of them are shown on the result page and because they were not completed in any of the iterations, we exclude the measurement (in some cases is a few nano seconds because of the possible successful steps) from the result list and geomean calculation:
image
  1. If a workload fails in some iterations, we show it as part of the failed workloads but include the successful iterations in results list and geomean calculation. Sentence similarity workloads failed for some random number of iterations in the below screenshot:
image

We can see the number of the iterations in the shown table for the workloads (sentence similarity on wasm, for example):

image

I also tested if the heights of the warning box is dynamic based on the number of the failed workloads and if it is not shown if all the workloads are successful.

@rmahdav rmahdav marked this pull request as ready for review February 28, 2026 01:50
@rmahdav
Copy link
Copy Markdown
Collaborator Author

rmahdav commented Feb 28, 2026

This PR does have conflict with PR #114 , I'll wait for that one to merge and then rebase this one on top of that.

@rmahdav rmahdav force-pushed the continue-when-a-workload-is-not-working branch from 5ddb5c0 to 7b6ff2e Compare March 6, 2026 20:26
@rmahdav rmahdav requested review from brendandahl and danleh March 12, 2026 18:11
@rmahdav
Copy link
Copy Markdown
Collaborator Author

rmahdav commented Mar 23, 2026

Friendly ping :) I am waiting for the review approval to merge this PR.

Copy link
Copy Markdown
Collaborator

@danleh danleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, forgot to approve, nothing else to comment on (modulo merge conflicts).

@rmahdav rmahdav force-pushed the continue-when-a-workload-is-not-working branch from 11ad59f to 6fcd125 Compare March 24, 2026 18:11
@rmahdav rmahdav merged commit dcac76c into main Mar 24, 2026
3 checks passed
@rmahdav rmahdav deleted the continue-when-a-workload-is-not-working branch March 24, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants