-
Notifications
You must be signed in to change notification settings - Fork 1.2k
RWS entry for Major League Baseball #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Everything seems to be in order, once you sign the CLA I'll commit this change |
"https://mlbstatic.com" | ||
], | ||
"rationaleBySite": { | ||
"https://mlbstatic.com": "Cookieless domain for serving static assets and images for MLB" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use RWS if this domain doesn't use cookies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The domain had been included on the MDL, assuming because we serve our analytics and advertising scripts from the domain. We added this RWS to get off of the MDL list. We added this RWS to reduce the risk of future versions of incognito Chrome from blocking MLB.com's MLBStatic.com dependencies
@wcolodette FYI, you will need to sign the CLA before we can merge this. |
The RWS JSON was successfully validated! |
No description provided.