Skip to content

core: remove ResponseCompression artifact #16755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
Merged

core: remove ResponseCompression artifact #16755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion core/config/default-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ const defaultConfig = {
{id: 'MainDocumentContent', gatherer: 'main-document-content'},
{id: 'MetaElements', gatherer: 'meta-elements'},
{id: 'NetworkUserAgent', gatherer: 'network-user-agent'},
{id: 'ResponseCompression', gatherer: 'dobetterweb/response-compression'},
{id: 'RobotsTxt', gatherer: 'seo/robots-txt'},
{id: 'Scripts', gatherer: 'scripts'},
{id: 'SourceMaps', gatherer: 'source-maps'},
Expand Down
136 changes: 0 additions & 136 deletions core/gather/gatherers/dobetterweb/response-compression.js
View file
Open in desktop

This file was deleted.

214 changes: 0 additions & 214 deletions core/test/gather/gatherers/dobetterweb/response-compression-test.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion core/test/scripts/run-mocha-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ const testsToIsolate = new Set([
'core/test/gather/snapshot-runner-test.js',
'core/test/gather/timespan-runner-test.js',
'core/test/user-flow-test.js',
'core/test/gather/gatherers/dobetterweb/response-compression-test.js',
'core/test/runner-test.js',

// These tend to timeout in puppeteer when run in parallel with other tests.
Expand Down
1 change: 0 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
"core/test/gather/gatherers/accessibility-test.js",
"core/test/gather/gatherers/console-messages-test.js",
"core/test/gather/gatherers/devtools-log-test.js",
"core/test/gather/gatherers/dobetterweb/response-compression-test.js",
"core/test/gather/gatherers/full-page-screenshot-test.js",
"core/test/gather/gatherers/global-listeners-test.js",
"core/test/gather/gatherers/html-without-javascript-test.js",
Expand Down
2 changes: 0 additions & 2 deletions types/artifacts.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,6 @@ export interface GathererArtifacts extends PublicGathererArtifacts {
JsUsage: Record<string, Omit<Crdp.Profiler.ScriptCoverage, 'url'>>;
/** The user agent string that Lighthouse used to load the page. Set to the empty string if unknown. */
NetworkUserAgent: string;
/** Size info of all network records sent without compression and their size after gzipping. */
ResponseCompression: {requestId: string, url: string, mimeType: string, transferSize: number, resourceSize: number, gzipSize?: number}[];
/** Information on fetching and the content of the /robots.txt file. */
RobotsTxt: {status: number|null, content: string|null, errorMessage?: string};
/** Source maps of scripts executed in the page. */
Expand Down
Loading