Shipping Features endpoint fix #5538
Merged
+22
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
reviewed
Oct 13, 2025
There was a problem hiding this comment.
Thanks for making this change! Reducing the API response to only the feature URL makes a lot of sense for improving performance and readability. The URL change also helps simplify the endpoint.
The code looks good to me. I've verified that the logic changes in shipping_features_api.py are correctly reflected in the updated tests in shipping_features_api_test.py.
This PR was reviewed by Gemini.
jrobbins
approved these changes
Oct 13, 2025
api/shipping_features_api.py
Outdated
|
|
||
| if feature.feature_type == FEATURE_TYPE_CODE_CHANGE_ID: | ||
| # PSA features do not require intents or approvals. | ||
| feature_dict = converters.feature_entry_to_json_verbose(feature) |
There was a problem hiding this comment.
Do you still need feature_dict? Avoiding this call would avoid more NDB operations.
There was a problem hiding this comment.
Ah, good catch - I did not remove this line
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 14, 2025
* less feature information in shipping features API * fix tests * revert temporary test change * remove unused line
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5498
This change adds two changes to the shipping features endpoint: