Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-deny maintenance #1863

Merged
merged 4 commits into from
Feb 26, 2025
Merged

Conversation

EliahKagan
Copy link
Member

@EliahKagan EliahKagan commented Feb 25, 2025

This removes RUSTSEC-2025-0007 as an allowed advisory since it has been withdrawn and therefore need no longer be listed, updates the versions of two Cargo.lock dependencies that have been yanked and whose updated versions fix what seem to be soundness bugs, and removes the old Unicode license from the allow list now that no dependencies use it. See commit messages for full details.

In 0e9299c (GitoxideLabs#1854), RUSTSEC-2025-0007 was listed as ignored to let
`cargo deny advisories` pass. That advisory has been withdrawn, as
noted in https://rustsec.org/advisories/RUSTSEC-2025-0007.html:

> After this advisory was published, the author graciously agreed
> to give access to the rustls team. The rustls team is committed
> to providing security (only) maintenance for *ring* for the
> foreseeable future.

It is no longer necessary to list that advisory as ignored.

This reverts commit 0e9299c.
`cargo deny` warns about `sdd` 3.0.4 being yanked. This upgrades it
to 3.0.7.

https://github.com/wvwwvwwv/scalable-delayed-dealloc/blob/main/CHANGELOG.md
describes 3.0.7 as "Fix a use-after-free issue when thread-local
storage is dropped." This seems worth bumping the version to in
Cargo.lock to be received in `--locked` builds.
`cargo deny` warns about the use of `scc` 2.2.5, which is yanked.

https://github.com/wvwwvwwv/scalable-concurrent-containers/blob/main/CHANGELOG.md
notes that `scc` 2.0.0 to 2.3.0 (inclusive) were affected by
wvwwvwwv/scalable-concurrent-containers#176
and yanked for that reason.

This upgrades to a non-yanked version where that use-after-free bug
is fixed.
`cargo deny` warned that "Unicode-DFS-2016" appeared in the list of
allowed licenses but was not used by any dependency. This list had
both "Unicode-3.0" and "Unicode-DFS-2016".

Possibly relevant is that `unicode-ident` updated its license
in 1.0.14 (dtolnay/unicode-ident#28),
changing from "Unicode-DFS-2016" to "Unicode-3.0".

The "Unicode-3.0" license was added to `deny.toml` in 5173e9a
(GitoxideLabs#1668), but "Unicode-DFS-2016" was not removed at that time. It
looks like some Unicode-related packages still used that license at
that time. But it does not seem to be needed here anymore.
@EliahKagan EliahKagan marked this pull request as ready for review February 25, 2025 22:39
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, much appreciated!

@Byron Byron merged commit 34b19d3 into GitoxideLabs:main Feb 26, 2025
21 checks passed
@EliahKagan EliahKagan deleted the run-ci/cargo-deny-next branch February 26, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants