Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify description of single escaping #1812

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

EliahKagan
Copy link
Member

This improves how gix_quote::single documents how it handles the cases it treats specially.

The fix in #717 (discussed in #713) wasn't accompanied by a change to the documentation, which continued either to describe the preceding behavior or to be ambiguous. This changes it to describe the current behavior unambiguously. Only documentation is changed.

This improves how `gix_quote::single` documents how it handles the
cases it treats specially.

The fix in GitoxideLabs#717 (discussed in GitoxideLabs#713) wasn't accompanied by a change
to the documentation, which continued either to describe the
preceding behavior or to be ambiguous. This changes it to describe
the current behavior unambiguously. Only documentation is changed.
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your help with this!

I remember having noticed this as well when using it for shell-command quotation, but then forgot to change it. So it's good this discrepancy isn't going to live on any longer.

@Byron Byron merged commit 6065af5 into GitoxideLabs:main Jan 26, 2025
21 checks passed
@EliahKagan EliahKagan deleted the single branch January 26, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants