Reenable fuzzing PRs again (seems OK with new nightly) #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reasons" This reverts commit a661a8a.
EliahKagan
changed the title
|
Thanks a lot for bringing fuzzing back! It's a bit sad that this currently is the biggest reason for instability, along with the WASI target being renamed, of course. |
Byron
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a661a8a ("deactivate fuzzing as it's not building anymore for unrelated reasons") from #1768. I'm not totally clear on the specific cause, but it appeared to be serde-related as in previous failures that went away when a more current nightly build was used.
Whereas in the past this required changes in oss-fuzz to update the rust toolchain (EliahKagan#1, google/oss-fuzz#12512, #1596), this time it looks like all that was required was to wait for a new nightly build. I say this based on testing in EliahKagan#8, with these results run three times.
I think that may, at least in principle, not be exactly equivalent to running it from here. So I waited for it to complete before marking this as ready to review (the fuzzing job is not a required check, so auto-merge would not wait for it). It passes here as well.