Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various improvements #1768

Merged
merged 4 commits into from
Jan 15, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Slightly improve docs of entry::Mode::change_to_match_fs()
  • Loading branch information
Byron committed Jan 15, 2025
commit 18b2a97544d779694ff3cdb27734513547d1cec2
2 changes: 1 addition & 1 deletion gix-index/src/entry/mod.rs
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ use bitflags::bitflags;

bitflags! {
/// The kind of file of an entry.
#[derive(Copy, Clone, Debug, PartialEq, Eq)]
#[derive(Copy, Clone, Debug, PartialEq, Eq, Ord, PartialOrd)]
pub struct Mode: u32 {
/// directory (only used for sparse checkouts), equivalent to a tree, which is _excluded_ from the index via
/// cone-mode.
4 changes: 2 additions & 2 deletions gix-index/src/entry/mode.rs
Original file line number Diff line number Diff line change
@@ -28,9 +28,9 @@ impl Mode {
/// If there is a type change then we will use whatever information is
/// present on the FS. Specifically if `has_symlinks` is false we will
/// never generate `Change::TypeChange { new_mode: Mode::SYMLINK }`. and
/// iff `executable_bit` is false we will never generate `Change::TypeChange
/// if `executable_bit` is false we will never generate `Change::TypeChange
/// { new_mode: Mode::FILE_EXECUTABLE }` (all files are assumed to be not
/// executable). That measn that unstaging and staging files can be a lossy
/// executable). That means that unstaging and staging files can be a lossy
/// operation on such file systems.
///
/// If a directory replaced a normal file/symlink we assume that the