Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reflog parsing #1732

Merged
merged 2 commits into from
Dec 22, 2024
Merged

fix reflog parsing #1732

merged 2 commits into from
Dec 22, 2024

Conversation

Byron
Copy link
Member

@Byron Byron commented Dec 21, 2024

When the reflog message contains >, the previous greedy parsing of the actors signature would cause too much to be consumed.
The idea is to always parse until \t which naturally separates the message from the well-defined parts.

@epage maybe you could have a look at this, as I am pretty sure that I have butchered winnow and I don't feel good about it.
The difficulty for me is to 'limit' what the actor parser can see at the \t location, while leaving the actor parsing as is. Maybe it's possible to 'pre-parse' from the right to '\t' so that
everything else naturally doesn't go beyond \t.

Thanks for your help.

Previously these confused the signature parser, who gladly
took the entire message as part of the email.
@Byron Byron marked this pull request as ready for review December 21, 2024 15:42
@Byron
Copy link
Member Author

Byron commented Dec 22, 2024

I am going to merge this to include the fix in the upcoming release. However, I hope that we will get to update the code to use winnow facilities eventually, right now it's a hack to workaround my ignorance.

@Byron Byron merged commit 8fd53bc into main Dec 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant