fuzz fix #1263
Merged
fuzz fix #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the fuzzer would create a section with 15k keys which all were `n`. The first `n` has a 136kb sized value which triggers an expensive normalization. All other `n` are empty, but previously caused accessing the long value again which is the first `n` it finds. Now we iterate values, and keep track of previous ones when doing multi-value access, which seems like a good test to have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the fuzzer would create a section with 15k keys
which all were
n. The firstnhas a 136kb sized valuewhich triggers an expensive normalization.
All other
nare empty, but previously caused accessing thelong value again which is the first
nit finds.Now we iterate values, and keep track of previous ones when
doing multi-value access, which seems like a good test to
have.