Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo-binstall support for gitoxide #1239

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

NobodyXu
Copy link
Contributor

@NobodyXu NobodyXu commented Jan 8, 2024

So that cargo-binstall can download official pre-built binaries from the github release.

Tested locally using cargo binstall --manifest-path Cargo.toml gitoxide --force --strategies crate-meta-data

So that `cargo-binstall` can download official pre-built binaries from
the github release.

Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Copy link
Contributor Author

NobodyXu commented Jan 8, 2024

It would be great if you can provide:

  • aarch64-apple-darwin builds
  • universal-apple-darwin builds
  • provide *-musl builds for all *-gnu builds
  • provide a new type of builds which uses zlib-ng for max perf and linked with it statically, uses rustls to avoid external openssl dep.

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for making this work! It's about time, too 😁.

It would be great if you can provide:

  • aarch64-apple-darwin builds
  • universal-apple-darwin builds
  • provide *-musl builds for all *-gnu builds
  • provide a new type of builds which uses zlib-ng for max perf and linked with it statically, uses rustls to avoid external openssl dep.

I agree, it would be great, and I'd be happy if someone with more knowledge or persistence with CI builds could take a stab at this. My current level of pre-built binaries is "Oh my, it works, let's hope it will stay that way so I don't have to touch it ever again".

What's here was basically copied from ripgrep at some point, and now is held together with duct-tape :D.

@Byron Byron merged commit 71ab298 into GitoxideLabs:main Jan 9, 2024
18 checks passed
@NobodyXu NobodyXu deleted the binstall branch January 9, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants