greatly reduce worst-case gix-config memory consumption #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Byron
commented
Jan 5, 2024
Byron
commented
- fix!: greatly reduce peak memory usage when reading files.
- add test for memory usage in worse-case scenario
Previously it was possible to cause a memory consumption of 2.5GB by merely reading a specifically tuned configuration file sized a little less than 1MB, a massive 2500x amplification. Data structures have been optimized and premature optimizations removed in favor of much more efficient memory usage. Now the same file causes a 50MB peak memory usage, still quite a lot, but also 50x less than before.
Byron
changed the title
|
Closing - it was merged but with changed commit messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.