RFC: remove "Copyright Sebastian Thiel ..." from LICENSE files #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Copyright Sebastian Thiel ..." line in the LICENSE files confuse our tooling and reviewers at Google, making it take longer than necessary to import new versions of Gitoxide into our monorepo. IIUC, the copyright is supposed to go in each source code file instead. Maybe it will become necessary to move it out of the LICENSE file as soon as the project decides to copy/vendor some code from somewhere else anwyay, because then we probably can't claim copyright for the entire repo? I'm not a lawyer and far from an export on this. If we remove the copyright line from the LICENSE files, does that mean that we should add them in each source file? I think I've heard that that's not necessary because the information about who wrote the code is available in the commit log..
|
I am happy to help with this, I probably copied the license file from somewhere as well. When it comes down to trying the copyright, from all I know one will look at detailed line-by-line authorship anyway and indeed use Git for that. And since each source tarball can always be traced back to its source commit or tag, there should be no need to mention names anywhere either. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Copyright Sebastian Thiel ..." line in the LICENSE files confuse our tooling and reviewers at Google, making it take longer than necessary to import new versions of Gitoxide into our monorepo. IIUC, the copyright is supposed to go in each source code file instead. Maybe it will become necessary to move it out of the LICENSE file as soon as the project decides to copy/vendor some code from somewhere else anwyay, because then we probably can't claim copyright for the entire repo? I'm not a lawyer and far from an export on this.
If we remove the copyright line from the LICENSE files, does that mean that we should add them in each source file? I think I've heard that that's not necessary because the information about who wrote the code is available in the commit log..